fix: missing dom type in tsconfig#639
Closed
eduardomourar wants to merge 2 commits intosmithy-lang:mainfrom
Closed
fix: missing dom type in tsconfig#639eduardomourar wants to merge 2 commits intosmithy-lang:mainfrom
eduardomourar wants to merge 2 commits intosmithy-lang:mainfrom
Conversation
Contributor
Author
|
Most probably the DOM types can be removed from the |
Contributor
|
@eduardomourar Can you create a new bug report for this issue From your PR description, I see that the issue exists, but would like to discuss the problem using a minimal repro and compare different solutions. |
AndrewFossAWS
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws/aws-sdk-js-v3#4204
Description of changes:
After PR #625, the DOM types have been removed from the default tsconfig.json file (before the value for lib included the DOM). This causes the following error during compilation:
This is change will allow compiling any recent generated Smithy project without modifying the tsconfig (as being done in the AWS SDK JS v3 repo here).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.